[EventDispatcher] [RFC] feat: swap from event constant to event class#20889
Merged
javiereguiluz merged 1 commit intosymfony:6.4from Apr 15, 2025
Merged
[EventDispatcher] [RFC] feat: swap from event constant to event class#20889javiereguiluz merged 1 commit intosymfony:6.4from
javiereguiluz merged 1 commit intosymfony:6.4from
Conversation
javiereguiluz
added
EventDispatcher
Status: Reviewed
and removed
Status: Needs Review
labels
carsonbot
changed the title
Member
|
Yes, this is better and we already use the new notation everywhere else. Thanks Antoine! |
Contributor
Author
|
go it thx, I will try to make a pass on the codebase for any leftover :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, another thing I notice in the doc is the usage of old "string" via (constant) for the event dispatcher and listener/subscriber
do you think it is worth it in sf v7+ to only document the "new way" via event class which is the event dispatched internally?
thank !